opt-dist: set build_llvm to false for WindowsCi
#144255
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suggested in rust-lang#143898 (comment). see rust-lang#143898 (comment) as the reason for such test
rustbot
added
the
S-waiting-on-author
rustbot
added
the
S-waiting-on-review
|
Some changes occurred in src/tools/opt-dist cc @Kobzol |
rustbot
removed
the
S-waiting-on-author
ognevny
changed the title
build_llvm to false for WindowsCibuild_llvm to false for WindowsCi
|
@bors2 try |
rust-bors bot
added a commit
that referenced
this pull request
Jul 21, 2025
[DONT MERGE] opt-dist: set `build_llvm` to false for WindowsCi suggested in #143898 (comment). see #143898 (comment) as the reason for such test <!-- homu-ignore:start --> <!-- If this PR is related to an unstable feature or an otherwise tracked effort, please link to the relevant tracking issue here. If you don't know of a related tracking issue or there are none, feel free to ignore this. This PR will get automatically assigned to a reviewer. In case you would like a specific user to review your work, you can assign it to them by using r? <reviewer name> --> <!-- homu-ignore:end --> r? `@ghost` cc `@Kobzol` for a try-job try-job: dist-x86_64-msvc
|
Can you try Windows perf. on the above artifact please? |
yes, but I need some time to get my laptop online... I'm far away from it |
$ hyperfine "cargo +67819923ac8ea353aaa775303f4c3aacbf41d010 build --release" "cargo +978fa844ca3da87b313190c4b047
f53a3cdb652f build --release" --prepare "cargo clean" --runs 5
Benchmark 1: cargo +67819923ac8ea353aaa775303f4c3aacbf41d010 build --release
Time (mean ± σ): 10.828 s ± 0.076 s [User: 77.439 s, System: 5.578 s]
Range (min … max): 10.759 s … 10.912 s 5 runs
Benchmark 2: cargo +978fa844ca3da87b313190c4b047f53a3cdb652f build --release
Time (mean ± σ): 10.769 s ± 0.066 s [User: 77.136 s, System: 5.519 s]
Range (min … max): 10.695 s … 10.853 s 5 runs
Summary
cargo +978fa844ca3da87b313190c4b047f53a3cdb652f build --release ran
1.01 ± 0.01 times faster than cargo +67819923ac8ea353aaa775303f4c3aacbf41d010 build --release |
|
Damn. I wonder if it makes sense to do PGO for Windows in this case.. I'll discuss on Zulip. |
|
should I remove |
|
Let's wait a bit if someone comes with any ideas on Zulip, otherwise we can probably just disable it, yeah. |
ognevny
changed the title
build_llvm to false for WindowsCibuild_llvm to false for WindowsCi
|
@bors try |
rust-bors bot
added a commit
that referenced
this pull request
Aug 7, 2025
opt-dist: set `build_llvm` to false for WindowsCi try-job: dist-x86_64-msvc
$ hyperfine "cargo +cd434309efcf5dc68b253e5ef6ba40c1c43711c9 build --release" "cargo +daed8a9de3006ead5bed8e19c3e50bae8c4e5256 build --release" --prepare "cargo clean" --runs 5
Benchmark 1: cargo +cd434309efcf5dc68b253e5ef6ba40c1c43711c9 build --release
Time (mean ± σ): 9.637 s ± 0.076 s [User: 72.870 s, System: 4.882 s]
Range (min … max): 9.551 s … 9.740 s 5 runs
Benchmark 2: cargo +daed8a9de3006ead5bed8e19c3e50bae8c4e5256 build --release
Time (mean ± σ): 9.871 s ± 0.246 s [User: 74.214 s, System: 5.082 s]
Range (min … max): 9.703 s … 10.293 s 5 runs
Summary
cargo +cd434309efcf5dc68b253e5ef6ba40c1c43711c9 build --release ran
1.02 ± 0.03 times faster than cargo +daed8a9de3006ead5bed8e19c3e50bae8c4e5256 build --release |
|
so what's status on this and #143898? will we move it forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggested in #143898 (comment). see #143898 (comment) as the reason for such test
r? @ghost
cc @Kobzol for a try-job
try-job: dist-x86_64-msvc